feat: add support for transfer entire balance for vesting accounts (backport #7650) #7676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…7650) * fix spendable bug * remove GetBalance from expected keeper --------- Co-authored-by: DimitrisJim <[email protected]> (cherry picked from commit b0d5778)
mergify
bot
requested review from
AdityaSripal,
damiannolan and
chatton
as code owners
|
DimitrisJim
approved these changes
Dec 12, 2024
damiannolan
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Thank you @gjermundgaraba for this! I missed the original PR.
Heads up I've created #7681 for v0.52 as vesting module is rugged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows for the "transfer entire balance" feature to work for vesting accounts.
closes: #7658
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.This is an automatic backport of pull request #7650 done by [Mergify](https://mergify.com).